Float and Uniform array support #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mt-caret thank you! It looks good. Is it ready for merging as-is ? |
|
Hey, thanks! Yup, both PRs are ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for uniform arrays (i.e. arrays where elements are guaranteed to be boxed) and floatarrays (unboxed float arrays). Bumps the version of ocaml-sys so we can use
caml_sys_double_fieldand the like.This sidesteps the issue of supporting
arrays in general where it's pretty painful to dispatch to the correct type in Rust when seeing the double array tag since it's somewhat non-trivial to specialize traits based on whether the OCaml type isOCamlFloat/f64.